From: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Date: Mon, 12 Jun 2023 10:06:03 +0000 (+0530)
Subject: config.c: fix memory leak in convert_controller_versions()
X-Git-Tag: v3.1.0~55
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1b53e2af890f07f519c7074d052380f6132850f1;p=thirdparty%2Flibcgroup.git

config.c: fix memory leak in convert_controller_versions()

Fix memory leak warning in convert_controller_versions(), reported by
Coverity tool:

CID 313911 (#1 of 1): Resource leak (RESOURCE_LEAK)9. leaked_storage:
Variable cgrp_cpy going out of scope leaks the storage it points to.

struct cgroup cgrp_cpy was not free'd in the success path, fix it.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
---

diff --git a/src/config.c b/src/config.c
index 83b7a955..76785784 100644
--- a/src/config.c
+++ b/src/config.c
@@ -852,7 +852,8 @@ next_controller:
 		cgroup_free_controller(cgc);
 		cgrp_cpy->index = 0;
 	}
-	return 0;
+
+	ret = 0;
 err:
 	cgroup_free(&convert_cgrp);
 	cgroup_free(&cgrp_cpy);