From: Laurent Pinchart Date: Wed, 18 Mar 2026 23:59:04 +0000 (+0200) Subject: media: renesas: vsp1: histo: Fix size enumeration X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1b5db4e308443227ed5b97d8e5c287c6fc34eb4b;p=thirdparty%2Fkernel%2Fstable.git media: renesas: vsp1: histo: Fix size enumeration The histogram supports size enumeration on the sink pad only, as the source pad outputs a metadata format. The correct error code when enumeration is not supported is -ENOTTY, not -EINVAL. Fix it. Tested-by: Lad Prabhakar # HiHope RZ/G2M Link: https://patch.msgid.link/20260318235907.831556-11-laurent.pinchart+renesas@ideasonboard.com Signed-off-by: Laurent Pinchart Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/renesas/vsp1/vsp1_histo.c b/drivers/media/platform/renesas/vsp1/vsp1_histo.c index f97aecb22058..313b9f3ce0f1 100644 --- a/drivers/media/platform/renesas/vsp1/vsp1_histo.c +++ b/drivers/media/platform/renesas/vsp1/vsp1_histo.c @@ -183,7 +183,7 @@ static int histo_enum_frame_size(struct v4l2_subdev *subdev, struct v4l2_subdev_frame_size_enum *fse) { if (fse->pad != HISTO_PAD_SINK) - return -EINVAL; + return -ENOTTY; return vsp1_subdev_enum_frame_size(subdev, sd_state, fse); }