From: Markus Valentin <markus.valentin@open-xchange.com>
Date: Thu, 15 May 2025 12:04:06 +0000 (+0200)
Subject: imap: cmd_append_handle_args() - Fix calling i_stream_create_limit() twice
X-Git-Tag: 2.4.2~784
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1b8098aa7880ee50f401c8756195f47574f163eb;p=thirdparty%2Fdovecot%2Fcore.git

imap: cmd_append_handle_args() - Fix calling i_stream_create_limit() twice

f12df6e0eed634aa4fe92c225b54ef5ee965b35c accidentally added a second
call to i_stream_create_limit() was which led to leaking events and
wrong iostream->refcount in other plugins
---

diff --git a/src/imap/cmd-append.c b/src/imap/cmd-append.c
index 195d0e7f18..3a831294ff 100644
--- a/src/imap/cmd-append.c
+++ b/src/imap/cmd-append.c
@@ -666,7 +666,6 @@ cmd_append_handle_args(struct client_command_context *cmd,
 		ctx->binary_input = args->literal8;
 		ctx->litinput = i_stream_create_limit(client->input, ctx->literal_size);
 		ctx->utf8_input = FALSE;
-		ctx->litinput = i_stream_create_limit(client->input, ctx->literal_size);
 		valid = TRUE;
 	} else {
 		ret = cmd_append_start_catenate(ctx, &args, &cat_list);