From: Phil Sutter Date: Mon, 22 Jul 2019 10:16:18 +0000 (+0200) Subject: ebtables: Fix error message for invalid parameters X-Git-Tag: v1.8.4~98 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1b8210f848631;p=thirdparty%2Fiptables.git ebtables: Fix error message for invalid parameters With empty ruleset, ebtables-nft would report the wrong argv: | % sudo ./install/sbin/ebtables-nft -vnL | ebtables v1.8.3 (nf_tables): Unknown argument: './install/sbin/ebtables-nft' | Try `ebtables -h' or 'ebtables --help' for more information. After a (successful) call to 'ebtables-nft -L', this would even segfault: | % sudo ./install/sbin/ebtables-nft -vnL | zsh: segmentation fault sudo ./install/sbin/ebtables-nft -vnL Fixes: acde6be32036f ("ebtables-translate: Fix segfault while parsing extension options") Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- diff --git a/iptables/xtables-eb.c b/iptables/xtables-eb.c index 171f41b0..b8d89ad9 100644 --- a/iptables/xtables-eb.c +++ b/iptables/xtables-eb.c @@ -1180,7 +1180,7 @@ print_zero: if (ebt_command_default(&cs)) xtables_error(PARAMETER_PROBLEM, "Unknown argument: '%s'", - argv[optind - 1]); + argv[optind]); if (command != 'A' && command != 'I' && command != 'D' && command != 'C')