From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 11 Jul 2025 12:13:55 +0000 (+0200)
Subject: dns: Fix another clang-tidy warning
X-Git-Tag: rec-5.4.0-alpha0~36^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1ba566f50364a09d7ffa7391f4928fa8019157d1;p=thirdparty%2Fpdns.git

dns: Fix another clang-tidy warning

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
---

diff --git a/pdns/dns.cc b/pdns/dns.cc
index cbab33e45c..7d1b772a2f 100644
--- a/pdns/dns.cc
+++ b/pdns/dns.cc
@@ -87,14 +87,14 @@ static const std::array<std::string, 24> rcodes_short_s =  {
 
 std::string RCode::to_s(uint8_t rcode) {
   if (rcode > 0xF) {
-    return std::string("ErrOutOfRange");
+    return "ErrOutOfRange";
   }
   return ERCode::to_s(rcode);
 }
 
 std::string RCode::to_short_s(uint8_t rcode) {
   if (rcode > 0xF) {
-    return std::string("ErrOutOfRange");
+    return "ErrOutOfRange";
   }
   return ERCode::to_short_s(rcode);
 }