From: Martin Kletzander Date: Fri, 19 May 2023 09:52:27 +0000 (+0200) Subject: qemu: Use thread-context even with numatune's restrictive mode X-Git-Tag: v9.4.0-rc1~26 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1bb439e4b0609aac0cd6ee3b1c0f5a5fcff0cc67;p=thirdparty%2Flibvirt.git qemu: Use thread-context even with numatune's restrictive mode We cannot use host-nodes attribute for it, but there is no reason for us to skip the preallocation optimisation using thread-context in such case. Thankfully returning the proper nodemask from qemuBuildMemoryBackendProps is enough to trigger this. Signed-off-by: Martin Kletzander Reviewed-by: Ján Tomko --- diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 2a6d9408f6..15383f646a 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3245,7 +3245,7 @@ qemuBuildMemoryGetPagesize(virQEMUDriverConfig *cfg, * @def: domain definition object * @mem: memory definition object * @force: forcibly use one of the backends - * @nodemaskRet: [out] bitmap used to format .host-nodes attribute + * @nodemaskRet: [out] bitmap where the memory should be allocated * * Creates a configuration object that represents memory backend of given guest * NUMA node (domain @def and @mem). Use @priv->autoNodeset to fine tune the @@ -3458,10 +3458,10 @@ qemuBuildMemoryBackendProps(virJSONValue **backendProps, "S:policy", qemuNumaPolicyTypeToString(mode), NULL) < 0) return -1; - - if (nodemaskRet) - *nodemaskRet = nodemask; } + + if (nodemaskRet) + *nodemaskRet = nodemask; } /* If none of the following is requested... */