From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 28 Dec 2017 14:33:29 +0000 (-0500)
Subject: use fr_rand_buffer()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1bbef18e8b3a3bfec508cb48f82681fc82af4fca;p=thirdparty%2Ffreeradius-server.git

use fr_rand_buffer()
---

diff --git a/src/modules/proto_radius/proto_radius_auth.c b/src/modules/proto_radius/proto_radius_auth.c
index d03f6f151f0..cdc725faf1c 100644
--- a/src/modules/proto_radius/proto_radius_auth.c
+++ b/src/modules/proto_radius/proto_radius_auth.c
@@ -412,14 +412,9 @@ static fr_io_final_t mod_process(REQUEST *request, fr_io_action_t action)
 		 */
 		if ((request->reply->code == FR_CODE_ACCESS_CHALLENGE) &&
 		    !(vp = fr_pair_find_by_num(request->reply->vps, 0, FR_STATE, TAG_ANY))) {
-			size_t i;
-			uint32_t x;
 			uint8_t buffer[16];
 
-			for (i = 0; i < sizeof(buffer) / sizeof(x); i++) {
-				x = fr_rand();
-				memcpy(buffer + (i * 4), &x, sizeof(x));
-			}
+			fr_rand_buffer(buffer, sizeof(buffer));
 
 			vp = fr_pair_afrom_num(request->reply, 0, FR_STATE);
 			if (vp) {