From: Volker Lendecke <vl@samba.org>
Date: Mon, 22 Dec 2025 21:03:47 +0000 (+0100)
Subject: smbd: Remove an unnecessary talloc_strdup()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1bcfe1cd2da79a90f29523e98a0afff791f751a5;p=thirdparty%2Fsamba.git

smbd: Remove an unnecessary talloc_strdup()

talloc_string_sub() already makes a copy first

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c
index 05cc1181645..57617252643 100644
--- a/source3/smbd/msdfs.c
+++ b/source3/smbd/msdfs.c
@@ -223,15 +223,7 @@ static NTSTATUS create_conn_struct_as_root(TALLOC_CTX *ctx,
 		servicename = "Unknown Service (snum == -1)";
 	}
 
-	connpath = talloc_strdup(conn, path);
-	if (!connpath) {
-		TALLOC_FREE(conn);
-		return NT_STATUS_NO_MEMORY;
-	}
-	connpath = talloc_string_sub(conn,
-				     connpath,
-				     "%S",
-				     servicename);
+	connpath = talloc_string_sub(conn, path, "%S", servicename);
 	if (!connpath) {
 		TALLOC_FREE(conn);
 		return NT_STATUS_NO_MEMORY;