From: Russell Bryant <russell@russellbryant.com>
Date: Thu, 29 Dec 2005 08:15:48 +0000 (+0000)
Subject: avoid multiple strlen calls in complete_queue
X-Git-Tag: 1.4.0-beta1~3115
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1bd94abf57394057f7bbc97625b03cdc77ba4d71;p=thirdparty%2Fasterisk.git

avoid multiple strlen calls in complete_queue


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7667 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/apps/app_queue.c b/apps/app_queue.c
index c1054de042..17bc06a263 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -3360,17 +3360,22 @@ static int queue_show(int fd, int argc, char **argv)
 static char *complete_queue(char *line, char *word, int pos, int state)
 {
 	struct ast_call_queue *q;
-	int which=0;
+	char *ret = NULL;
+	int which = 0;
+	int wordlen = strlen(word);
 	
 	ast_mutex_lock(&qlock);
 	for (q = queues; q; q = q->next) {
-		if (!strncasecmp(word, q->name, strlen(word))) {
-			if (++which > state)
+		if (!strncasecmp(word, q->name, wordlen)) {
+			if (++which > state) {
+				ret = strdup(q->name);	
 				break;
+			}
 		}
 	}
 	ast_mutex_unlock(&qlock);
-	return q ? strdup(q->name) : NULL;
+
+	return ret;
 }
 
 /*!\brief callback to display queues status in manager