From: Darren Tucker Date: Fri, 22 Jul 2022 00:45:47 +0000 (+1000) Subject: Remove seed_rng calls from scp, sftp, sftp-server. X-Git-Tag: V_9_1_P1~79 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1bdf86725b77733bb5f17c54888b88a10b2f6538;p=thirdparty%2Fopenssh-portable.git Remove seed_rng calls from scp, sftp, sftp-server. These binaries don't use OpenSSL's random functions. The next step will be to stop linking them against libcrypto. ok djm@ --- diff --git a/scp.c b/scp.c index da07e64ec..f9ca5d393 100644 --- a/scp.c +++ b/scp.c @@ -455,8 +455,6 @@ main(int argc, char **argv) /* Ensure that fds 0, 1 and 2 are open or directed to /dev/null */ sanitise_stdfd(); - seed_rng(); - msetlocale(); /* Copy argv, because we modify it */ diff --git a/sftp-server-main.c b/sftp-server-main.c index 06566d36e..2c70f89bc 100644 --- a/sftp-server-main.c +++ b/sftp-server-main.c @@ -42,8 +42,6 @@ main(int argc, char **argv) /* Ensure that fds 0, 1 and 2 are open or directed to /dev/null */ sanitise_stdfd(); - seed_rng(); - if ((user_pw = getpwuid(getuid())) == NULL) { fprintf(stderr, "No user found for uid %lu\n", (u_long)getuid()); diff --git a/sftp.c b/sftp.c index c880f1661..939b8dc00 100644 --- a/sftp.c +++ b/sftp.c @@ -2406,8 +2406,6 @@ main(int argc, char **argv) sanitise_stdfd(); msetlocale(); - seed_rng(); - __progname = ssh_get_progname(argv[0]); memset(&args, '\0', sizeof(args)); args.list = NULL;