From: David S. Miller <davem@davemloft.net>
Date: Fri, 9 May 2008 06:40:26 +0000 (-0700)
Subject: sit: Add missing kfree_skb() on pskb_may_pull() failure.
X-Git-Tag: v2.6.25.3~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1be05a5eda841014c1151cb0f8dc791862bd40a5;p=thirdparty%2Fkernel%2Fstable.git

sit: Add missing kfree_skb() on pskb_may_pull() failure.

[ Upstream commit: 36ca34cc3b8335eb1fe8bd9a1d0a2592980c3f02 ]

Noticed by Paul Marks <paul@pmarks.net>.

Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index 1656c003b9895..4de86c4b65a1d 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -446,9 +446,9 @@ static int ipip6_rcv(struct sk_buff *skb)
 	}
 
 	icmp_send(skb, ICMP_DEST_UNREACH, ICMP_PORT_UNREACH, 0);
-	kfree_skb(skb);
 	read_unlock(&ipip6_lock);
 out:
+	kfree_skb(skb);
 	return 0;
 }