From: bugreport%peshkin.net <>
Date: Mon, 23 Dec 2002 09:49:07 +0000 (+0000)
Subject: Bug 186383 Checksetup leaves editor backups of localconfig accessible (revised)
X-Git-Tag: bugzilla-2.17.3~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1be7ce91dafe74df3db6d96c415dead9a68ce327;p=thirdparty%2Fbugzilla.git

Bug 186383 Checksetup leaves editor backups of localconfig accessible (revised)
r=jaypee
a=justdave
---

diff --git a/checksetup.pl b/checksetup.pl
index 18b45dda5a..a79b78a0d6 100755
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -820,12 +820,35 @@ if ($my_create_htaccess) {
     open HTACCESS, ">.htaccess";
     print HTACCESS <<'END';
 # don't allow people to retrieve non-cgi executable files or our private data
-<FilesMatch ^(.*\.pl|localconfig|processmail|runtests.sh)$>
+<FilesMatch ^(.*\.pl|.*localconfig.*|processmail|runtests.sh)$>
   deny from all
 </FilesMatch>
+<FilesMatch ^(localconfig.js|localconfig.rdf)$>
+  allow from all
+</FilesMatch>
 END
     close HTACCESS;
     chmod $fileperm, ".htaccess";
+  } else {
+    # 2002-12-21 Bug 186383
+    open HTACCESS, ".htaccess";
+    my $oldaccess = "";
+    while (<HTACCESS>) {
+      $oldaccess .= $_;
+    }
+    close HTACCESS;
+    if ($oldaccess =~ s/\|localconfig\|/\|.*localconfig.*\|/) {
+      print "Repairing .htaccess...\n";
+      open HTACCESS, ">.htaccess";
+      print HTACCESS $oldaccess;
+      print HTACCESS <<'END';
+<FilesMatch ^(localconfig.js|localconfig.rdf)$>
+  allow from all
+</FilesMatch>
+END
+      close HTACCESS;
+    }
+
   }
   if (!-e "Bugzilla/.htaccess") {
     print "Creating Bugzilla/.htaccess...\n";