From: James Jones <jejones3141@gmail.com>
Date: Wed, 27 Apr 2022 19:17:12 +0000 (-0500)
Subject: Remove needless check for NULL fp (CID #1503900) (#4468)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1bec9c8c07ede8d56b6acdb454c4b9e548c49d9c;p=thirdparty%2Ffreeradius-server.git

Remove needless check for NULL fp (CID #1503900) (#4468)
---

diff --git a/src/bin/dhcpclient.c b/src/bin/dhcpclient.c
index d06da8ba594..f269f019949 100644
--- a/src/bin/dhcpclient.c
+++ b/src/bin/dhcpclient.c
@@ -171,7 +171,7 @@ static int request_init(fr_radius_packet_t **out, fr_pair_list_t *packet_vps, ch
 	if (fr_pair_list_afrom_file(packet, dict_dhcpv4, packet_vps, fp, &filedone) < 0) {
 		fr_perror("dhcpclient");
 		fr_radius_packet_free(&packet);
-		if (fp && (fp != stdin)) fclose(fp);
+		if (fp != stdin) fclose(fp);
 		return -1;
 	}
 
@@ -212,7 +212,7 @@ static int request_init(fr_radius_packet_t **out, fr_pair_list_t *packet_vps, ch
 
 	} /* loop over the VP's we read in */
 
-	if (fp && (fp != stdin)) fclose(fp);
+	if (fp != stdin) fclose(fp);
 
 	/*
 	 *	And we're done.