From: Kamalesh Babulal Date: Tue, 15 Feb 2022 07:00:32 +0000 (+0530) Subject: test-007: make it PEP8 compliant X-Git-Tag: v3.1.0~308^2~2^2~96 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1c3fe3abe263a37bbc98100abec31dfb8df475d9;p=thirdparty%2Flibcgroup.git test-007: make it PEP8 compliant Make test 007-cgrules-basic_cgrules_v2.py PEP-8 compliant. Signed-off-by: Kamalesh Babulal Signed-off-by: Tom Hromatka --- diff --git a/ftests/007-cgrules-basic_cgrules_v2.py b/ftests/007-cgrules-basic_cgrules_v2.py index 95ded772..097ea752 100755 --- a/ftests/007-cgrules-basic_cgrules_v2.py +++ b/ftests/007-cgrules-basic_cgrules_v2.py @@ -21,43 +21,46 @@ # from cgroup import Cgroup, CgroupVersion +from process import Process import consts import ftests -import os -from process import Process import sys +import os -CONTROLLER='cpuset' -CGNAME='007cgrules' +CONTROLLER = 'cpuset' +CGNAME = '007cgrules' # move all perl processes to the 007cgrules cgroup in the # cpuset controller -CGRULE="*:/usr/bin/perl cpuset {}".format(CGNAME) +CGRULE = '*:/usr/bin/perl cpuset {}'.format(CGNAME) cg = Cgroup(CGNAME) + def prereqs(config): result = consts.TEST_PASSED cause = None if config.args.container: result = consts.TEST_SKIPPED - cause = "This test cannot be run within a container" + cause = 'This test cannot be run within a container' return result, cause if CgroupVersion.get_version('cpuset') != CgroupVersion.CGROUP_V2: result = consts.TEST_SKIPPED - cause = "This test requires the cgroup v2 cpuset controller" + cause = 'This test requires the cgroup v2 cpuset controller' return result, cause return result, cause + def setup(config): Cgroup.create(config, CONTROLLER, CGNAME) Cgroup.set_cgrules_conf(config, CGRULE, append=False) cg.start_cgrules(config) + def test(config): result = consts.TEST_PASSED cause = None @@ -68,17 +71,22 @@ def test(config): # proc/{pid}/cgroup alsways prepends a '/' to the cgroup path if proc_cgroup != os.path.join('/', CGNAME): result = consts.TEST_FAILED - cause = "PID {} was expected to be in cgroup {} but is in cgroup {}".format( - pid, os.path.join('/', CGNAME), proc_cgroup) + cause = ( + 'PID {} was expected to be in cgroup {} but is in ' + 'cgroup {}' + ''.format(pid, os.path.join('/', CGNAME), proc_cgroup) + ) return result, cause + def teardown(config): # destroy the child processes config.process.join_children(config) cg.join_children(config) Cgroup.delete(config, CONTROLLER, CGNAME, recursive=False) + def main(config): [result, cause] = prereqs(config) if result != consts.TEST_PASSED: @@ -92,6 +100,7 @@ def main(config): return [result, cause] + if __name__ == '__main__': config = ftests.parse_args() # this test was invoked directly. run only it