From: Bhagya Tholpady (bbantwal) <bbantwal@cisco.com>
Date: Thu, 25 Feb 2021 15:44:08 +0000 (+0000)
Subject: Merge pull request #2767 in SNORT/snort3 from ~BBANTWAL/snort3:alias_fix to master
X-Git-Tag: 3.1.2.0~25
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1c60424129105ce2a04831216ee5c08f57ee0843;p=thirdparty%2Fsnort3.git

Merge pull request #2767 in SNORT/snort3 from ~BBANTWAL/snort3:alias_fix to master

Squashed commit of the following:

commit aec73724ee2ba89181730c41662031e90ef4232d
Author: Bhagya Tholpady <bbantwal@cisco.com>
Date:   Wed Feb 24 16:55:10 2021 -0500

    managers: Perform sanity checks on set_alias() parameters
---

diff --git a/src/managers/module_manager.cc b/src/managers/module_manager.cc
index fe9542e17..34c1d8ee4 100644
--- a/src/managers/module_manager.cc
+++ b/src/managers/module_manager.cc
@@ -640,6 +640,9 @@ SO_PUBLIC void clear_alias()
 
 SO_PUBLIC bool set_alias(const char* from, const char* to)
 {
+    if ( !from or !to )
+        return false;
+
     const Module* m = ModuleManager::get_module(to);
 
     if ( !m or !m->is_bindable() )