From: Andreas Schneider Date: Mon, 12 Aug 2019 16:49:37 +0000 (+0200) Subject: Revert "s4:rpc_server: Use generate_secret_buffer() for netlogon challange" X-Git-Tag: tdb-1.4.2~118 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1c68085404cd467c217640e3eabfc4b7f8b1ce9f;p=thirdparty%2Fsamba.git Revert "s4:rpc_server: Use generate_secret_buffer() for netlogon challange" This reverts commit a21770cfdffd2a21045a1bc87e489af0f4c6f130. Reviewed-by: Alexander Bokovoy --- diff --git a/source4/rpc_server/netlogon/dcerpc_netlogon.c b/source4/rpc_server/netlogon/dcerpc_netlogon.c index f4e24b7fd7f..ac745e32b02 100644 --- a/source4/rpc_server/netlogon/dcerpc_netlogon.c +++ b/source4/rpc_server/netlogon/dcerpc_netlogon.c @@ -90,8 +90,7 @@ static NTSTATUS dcesrv_netr_ServerReqChallenge(struct dcesrv_call_state *dce_cal pipe_state->client_challenge = *r->in.credentials; - /* We need to use a CSPRNG which reseeds for generating session keys. */ - generate_secret_buffer(pipe_state->server_challenge.data, + generate_random_buffer(pipe_state->server_challenge.data, sizeof(pipe_state->server_challenge.data)); *r->out.return_credentials = pipe_state->server_challenge;