From: Stefan Metzmacher <metze@samba.org>
Date: Sun, 6 Apr 2025 19:05:12 +0000 (+0200)
Subject: lib/util: fix NONNULL(params) __attribute__((nonnull(params)))
X-Git-Tag: tevent-0.17.0~278
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1c76a075b73b927d54646787fe2feba0b5d7beb9;p=thirdparty%2Fsamba.git

lib/util: fix NONNULL(params) __attribute__((nonnull(params)))

This should be set on the function prototype itself specifying
all non null arguments e.g.

NONNULL(1) NONNULL(3)
int foo(const char *arg1, int arg2, const char *arg3);

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/lib/util/attr.h b/lib/util/attr.h
index af3e2442b3a..f458a06f01b 100644
--- a/lib/util/attr.h
+++ b/lib/util/attr.h
@@ -72,9 +72,9 @@
 
 #ifndef NONNULL
 #if __has_attribute(nonnull) || ( (__GNUC__ >= 3) && (__GNUC_MINOR__ >= 1 ) )
-#define NONNULL(param) param __attribute__((nonnull))
+#define NONNULL(param) __attribute__((nonnull(param)))
 #else
-#define NONNULL(param) param
+#define NONNULL(param)
 #endif
 #endif