From: Razvan Becheriu Date: Tue, 2 May 2023 12:49:37 +0000 (+0300) Subject: [#2798] fixed compilation warnings X-Git-Tag: Kea-2.3.8~197 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1c887d69bfec471869c42a6202d0eb786cc5e09c;p=thirdparty%2Fkea.git [#2798] fixed compilation warnings --- diff --git a/src/bin/netconf/netconf.cc b/src/bin/netconf/netconf.cc index 5d8e3fd2a6..2bd681a617 100644 --- a/src/bin/netconf/netconf.cc +++ b/src/bin/netconf/netconf.cc @@ -449,7 +449,7 @@ NetconfAgent::subscribeToDataChanges(const CfgServersMapPair& service_pair) { } Subscription subscription( running_sess_->onModuleChange(model, callback, nullopt, 0, options)); - subscriptions_.emplace(server, forward(subscription)); + subscriptions_.emplace(server, std::forward(subscription)); } catch (exception const& ex) { ostringstream msg; msg << "module change subscribe failed with " << ex.what(); @@ -488,7 +488,7 @@ NetconfAgent::subscribeToNotifications(const CfgServersMapPair& service_pair) { }; try { Subscription subscription(running_sess_->onNotification(model, callback)); - subscriptions_.emplace(server, forward(subscription)); + subscriptions_.emplace(server, std::forward(subscription)); } catch (exception const& ex) { ostringstream msg; msg << "event notification subscription for model " << model << diff --git a/src/hooks/dhcp/high_availability/tests/communication_state_unittest.cc b/src/hooks/dhcp/high_availability/tests/communication_state_unittest.cc index 501fc0e883..8c33c094ed 100644 --- a/src/hooks/dhcp/high_availability/tests/communication_state_unittest.cc +++ b/src/hooks/dhcp/high_availability/tests/communication_state_unittest.cc @@ -978,6 +978,15 @@ TEST_F(CommunicationStateTest, partnerStateTestMultiThreading) { partnerStateTest(); } +TEST_F(CommunicationStateTest, partnerStateUnavailableTest) { + partnerStateUnavailableTest(); +} + +TEST_F(CommunicationStateTest, partnerStateUnavailableTestMultiThreading) { + MultiThreadingMgr::instance().setMode(true); + partnerStateUnavailableTest(); +} + TEST_F(CommunicationStateTest, partnerScopesTest) { partnerScopesTest(); } diff --git a/src/lib/cc/tests/simple_parser_unittest.cc b/src/lib/cc/tests/simple_parser_unittest.cc index 58aa40d6b8..51fff614ac 100644 --- a/src/lib/cc/tests/simple_parser_unittest.cc +++ b/src/lib/cc/tests/simple_parser_unittest.cc @@ -251,7 +251,7 @@ TEST_F(SimpleParserTest, getInteger) { // The value specified is 100. ElementPtr json = Element::fromJSON("{ \"bar\": 100 }"); - int64_t x; + int64_t x = -1; // Positive case: we expect value in range 0..200. All ok. EXPECT_NO_THROW(x = SimpleParser::getInteger(json, "bar", 0, 200)); diff --git a/src/lib/dhcp/tests/option_custom_unittest.cc b/src/lib/dhcp/tests/option_custom_unittest.cc index 56e6d6c27c..27c3a438c7 100644 --- a/src/lib/dhcp/tests/option_custom_unittest.cc +++ b/src/lib/dhcp/tests/option_custom_unittest.cc @@ -1737,13 +1737,13 @@ TEST_F(OptionCustomTest, setUint16DataArray) { ASSERT_EQ(3, option->getDataFieldsNum()); // Check that the values have been correctly set. - uint16_t value0; + uint16_t value0 = 0; ASSERT_NO_THROW(value0 = option->readInteger(0)); EXPECT_EQ(67, value0); - uint16_t value1; + uint16_t value1 = 0; ASSERT_NO_THROW(value1 = option->readInteger(1)); EXPECT_EQ(876, value1); - uint16_t value2; + uint16_t value2 = 0; ASSERT_NO_THROW(value2 = option->readInteger(2)); EXPECT_EQ(32222, value2); } @@ -2042,7 +2042,7 @@ TEST_F(OptionCustomTest, setRecordData) { ASSERT_EQ(9, option->getDataFieldsNum()); // Check that the default values have been correctly set. - uint16_t value0; + uint16_t value0 = 0; ASSERT_NO_THROW(value0 = option->readInteger(0)); EXPECT_EQ(0, value0); bool value1 = true; @@ -2133,7 +2133,7 @@ TEST_F(OptionCustomTest, setRecordArrayData) { ASSERT_EQ(9, option->getDataFieldsNum()); // Check that the default values have been correctly set. - uint16_t value0; + uint16_t value0 = 0; ASSERT_NO_THROW(value0 = option->readInteger(0)); EXPECT_EQ(0, value0); bool value1 = true; @@ -2368,7 +2368,7 @@ TEST_F(OptionCustomTest, unpackRecordArray) { ASSERT_EQ(4, option->getDataFieldsNum()); // We expect a 16 bit integer - uint16_t value0; + uint16_t value0 = 0; ASSERT_NO_THROW(value0 = option->readInteger(0)); EXPECT_EQ(8712, value0); diff --git a/src/lib/dhcpsrv/tests/client_class_def_unittest.cc b/src/lib/dhcpsrv/tests/client_class_def_unittest.cc index 429c7c2974..8fc5aed213 100644 --- a/src/lib/dhcpsrv/tests/client_class_def_unittest.cc +++ b/src/lib/dhcpsrv/tests/client_class_def_unittest.cc @@ -732,10 +732,10 @@ TEST(ClientClassDictionary, unparseDict) { "\"option-data\": [ ] }"); }; - std::string expected = "[\n" + - add_defaults("one") + ",\n" + - add_defaults("two") + ",\n" + - add_defaults("three") + "]\n"; + std::string expected = "[\n"; + expected += add_defaults("one") + ",\n"; + expected += add_defaults("two") + ",\n"; + expected += add_defaults("three") + "]\n"; runToElementTest(expected, *dictionary); } @@ -1587,10 +1587,10 @@ TEST(ClientClassDictionary, templateUnparseDict) { "\"option-data\": [ ] }"); }; - std::string expected = "[\n" + - add_defaults("one") + ",\n" + - add_defaults("two") + ",\n" + - add_defaults("three") + "]\n"; + std::string expected = "[\n"; + expected += add_defaults("one") + ",\n"; + expected += add_defaults("two") + ",\n"; + expected += add_defaults("three") + "]\n"; runToElementTest(expected, *dictionary); } diff --git a/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc b/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc index 0cca269d2d..489f7cca0c 100644 --- a/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc +++ b/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc @@ -1296,9 +1296,9 @@ TEST_F(ParseConfigTest, encapsulatedOptionData) { (getOptionPtr(MAPE_V6_OPTION_SPACE, D6O_S46_RULE)); ASSERT_TRUE(s46_rule); - uint8_t flags; - uint8_t ea_len; - uint8_t prefix4_len; + uint8_t flags = 0; + uint8_t ea_len = 0; + uint8_t prefix4_len = 0; IOAddress ipv4_prefix(IOAddress::IPV4_ZERO_ADDRESS()); PrefixTuple ipv6_prefix(PrefixLen(0), IOAddress::IPV6_ZERO_ADDRESS());; diff --git a/src/lib/http/tests/request_unittests.cc b/src/lib/http/tests/request_unittests.cc index f902400420..9ba987e348 100644 --- a/src/lib/http/tests/request_unittests.cc +++ b/src/lib/http/tests/request_unittests.cc @@ -139,7 +139,7 @@ TEST_F(HttpRequestTest, includeHeaders) { ASSERT_NO_THROW(content_type = request_->getHeaderValue("Content-Type")); EXPECT_EQ("application/json", content_type); - uint64_t content_length; + uint64_t content_length = 0; ASSERT_NO_THROW( content_length = request_->getHeaderValueAsUint64("Content-Length") );