From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Wed, 24 Aug 2022 17:06:09 +0000 (-0400)
Subject: fix mock issue in pool test
X-Git-Tag: rel_2_0_0b1~93
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1c9da1e1d7ef7994328de2248b69a1a582766272;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

fix mock issue in pool test

Due to the change for #5648 in ad14471bc99c2fb2315d3333a95dd,
the mock in test_recycle_pool_no_race needs to implement
an empty handle_error dispatcher.

the exception was in a thread so did not interrupt the
test suite:

File "/home/classic/dev/sqlalchemy/lib/sqlalchemy/engine/base.py", line 2059, in _handle_dbapi_exception
      for fn in self.dialect.dispatch.handle_error:
  TypeError: 'Mock' object is not iterable

Change-Id: I764357c48aa1bf53a572d8ee24c89a7463505092
---

diff --git a/test/engine/test_pool.py b/test/engine/test_pool.py
index 2bbb976a84..c66ebfa6c6 100644
--- a/test/engine/test_pool.py
+++ b/test/engine/test_pool.py
@@ -1663,6 +1663,7 @@ class QueuePoolTest(PoolTestBase):
 
         dialect = Mock()
         dialect.is_disconnect = lambda *arg, **kw: True
+        dialect.dispatch = Mock(handle_error=[])
         dialect.dbapi.Error = dialect.loaded_dbapi.Error = Error
 
         pools = []