From: James Jones <jejones3141@gmail.com>
Date: Wed, 24 Aug 2022 22:01:59 +0000 (-0500)
Subject: Annotate false positive uninit (CID #1504020) (#4692)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1cbc5d0216ebfeb6a933125daed183425ca8718f;p=thirdparty%2Ffreeradius-server.git

Annotate false positive uninit (CID #1504020) (#4692)

coverity doesn't realize that at this point ether is necessarily
initialized, with all the fr_base16_decode()s successful.
---

diff --git a/src/lib/util/value.c b/src/lib/util/value.c
index 53568bc6ecb..6834728fba1 100644
--- a/src/lib/util/value.c
+++ b/src/lib/util/value.c
@@ -4922,6 +4922,7 @@ parse:
 		fr_base16_decode(&err, &dbuff, &our_in, true);
 		if (err != FR_SBUFF_PARSE_OK) goto ether_error;
 
+		/* coverity[uninit_use_in_call] */
 		fr_value_box_ethernet_addr(dst, dst_enumv, &ether, tainted);
 
 		return fr_sbuff_set(in, &our_in);