From: Michal Privoznik Date: Fri, 8 Mar 2024 14:12:15 +0000 (+0100) Subject: ch: Demote error when CH driver fails to init X-Git-Tag: v10.2.0-rc1~91 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1cc5d7df9a51ce13e481c7e50e763924c676b0bb;p=thirdparty%2Flibvirt.git ch: Demote error when CH driver fails to init If the host doesn't have /dev/kvm nor /dev/mshv, i.e. CH driver is unable to run any guests, then an error is reported. But the usual thing to do here is print an info message into the logs and return VIR_DRV_STATE_INIT_SKIPPED. It is a recoverable error after all. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 2601eea44b..9394924f2d 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -893,9 +893,8 @@ static int chStateInitialize(bool privileged, VIR_ARCH_NONE, VIR_DOMAIN_VIRT_KVM) && !virCapabilitiesDomainSupported(ch_driver->caps, -1, VIR_ARCH_NONE, VIR_DOMAIN_VIRT_HYPERV)) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("/dev/kvm and /dev/mshv are missing. CH driver failed to initialize.")); - return VIR_DRV_STATE_INIT_ERROR; + VIR_INFO("/dev/kvm and /dev/mshv are missing. CH driver failed to initialize."); + return VIR_DRV_STATE_INIT_SKIPPED; } if (!(ch_driver->xmlopt = chDomainXMLConfInit(ch_driver)))