From: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Date: Wed, 18 Apr 2018 14:17:37 +0000 (+0300)
Subject: check scripts: handle unintialized driver vars in check-driverimpls.pl
X-Git-Tag: v4.3.0-rc1~166
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1ccaf39402a502d5bed77d94067d86a679b65a6b;p=thirdparty%2Flibvirt.git

check scripts: handle unintialized driver vars in check-driverimpls.pl

Current script confuses on lines like this:

static virHypervisorDriver parallelsHypervisorDriver;

It interprets next lines as if there is open brace.

Let's filter this case from matches.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/check-driverimpls.pl b/src/check-driverimpls.pl
index 4c28f2092a..832a3900f4 100755
--- a/src/check-driverimpls.pl
+++ b/src/check-driverimpls.pl
@@ -67,7 +67,7 @@ while (<>) {
                 $status = 1;
             }
         }
-    } elsif (/^(?:static\s+)?(vir(?:\w+)?Driver)\s+/) {
+    } elsif (/^(?:static\s+)?(vir(?:\w+)?Driver)\s+(?!.*;)/) {
         next if $1 eq "virNWFilterCallbackDriver" ||
                 $1 eq "virNWFilterTechDriver" ||
                 $1 eq "virConnectDriver";