From: William Dauchy <w.dauchy@criteo.com>
Date: Fri, 2 Oct 2020 13:27:20 +0000 (+0200)
Subject: MINOR: ssl: remove uneeded check in crtlist_parse_file
X-Git-Tag: v2.3-dev6~120
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1d0206e71f2c1d63b8323f64b51f2bbd64e078fd;p=thirdparty%2Fhaproxy.git

MINOR: ssl: remove uneeded check in crtlist_parse_file

this condition is never true as we either break or goto error, so those
two lines could be removed in the current state of the code.

this is fixing github issue #862

Signed-off-by: William Dauchy <w.dauchy@criteo.com>
---

diff --git a/src/ssl_crtlist.c b/src/ssl_crtlist.c
index 3c94bcf99e..3f09c86738 100644
--- a/src/ssl_crtlist.c
+++ b/src/ssl_crtlist.c
@@ -599,9 +599,6 @@ int crtlist_parse_file(char *file, struct bind_conf *bind_conf, struct proxy *cu
 				}
 			}
 		}
-		if (cfgerr & ERR_CODE)
-			goto error;
-
 		entry = NULL;
 	}