From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 13 Jan 2023 13:02:09 +0000 (+0100)
Subject: dnsdist: Add more unit tests for the packet overlay
X-Git-Tag: dnsdist-1.8.0-rc1~109^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1d0da3970b518c283d57b47deb7fb00950f6a3a3;p=thirdparty%2Fpdns.git

dnsdist: Add more unit tests for the packet overlay
---

diff --git a/pdns/dnsdistdist/test-dnsdist-dnsparser.cc b/pdns/dnsdistdist/test-dnsdist-dnsparser.cc
index a20dd82650..6bca068f67 100644
--- a/pdns/dnsdistdist/test-dnsdist-dnsparser.cc
+++ b/pdns/dnsdistdist/test-dnsdist-dnsparser.cc
@@ -71,6 +71,13 @@ BOOST_AUTO_TEST_CASE(test_Overlay)
     pwR.addOpt(4096, 0, 0);
     pwR.commit();
 
+    {
+      // check packet smaller than dnsheader
+      BOOST_CHECK_THROW(dnsdist::DNSPacketOverlay(std::string_view(reinterpret_cast<const char*>(response.data()), 11U)), std::runtime_error);
+      // check corrupted packet
+      BOOST_CHECK_THROW(dnsdist::DNSPacketOverlay(std::string_view(reinterpret_cast<const char*>(response.data()), response.size() - 1)), std::runtime_error);
+    }
+
     dnsdist::DNSPacketOverlay overlay(std::string_view(reinterpret_cast<const char*>(response.data()), response.size()));
     BOOST_CHECK_EQUAL(overlay.d_qname, target);
     BOOST_CHECK_EQUAL(overlay.d_qtype, QType::ANY);