From: Nick Porter <nick@portercomputing.co.uk>
Date: Mon, 7 Oct 2024 15:56:04 +0000 (+0100)
Subject: No need for a trailing zero byte after DHCPv4 end of options
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1d62303e5c57f2aecab1dfb8af38b4fc767b38fd;p=thirdparty%2Ffreeradius-server.git

No need for a trailing zero byte after DHCPv4 end of options
---

diff --git a/src/protocols/dhcpv4/base.c b/src/protocols/dhcpv4/base.c
index 3bfa3f83052..e9b1c874cc1 100644
--- a/src/protocols/dhcpv4/base.c
+++ b/src/protocols/dhcpv4/base.c
@@ -527,7 +527,7 @@ ssize_t fr_dhcpv4_encode_dbuff(fr_dbuff_t *dbuff, dhcp_packet_t *original, int c
 		if (len <= 0) break;
 	}
 
-	FR_DBUFF_IN_BYTES_RETURN(&work_dbuff, FR_END_OF_OPTIONS, 0x00);
+	FR_DBUFF_IN_RETURN(&work_dbuff, (uint8_t)FR_END_OF_OPTIONS);
 
 	/*
 	 *	FIXME: if (fr_dbuff_used(&work_dbuff) > mms),