From: Christoph Grüninger <foss@grueninger.de>
Date: Wed, 14 May 2025 19:16:19 +0000 (+0200)
Subject: decision.c: Simplify else condition
X-Git-Tag: 0.7.33~4^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1de3398f867f8c8d3124a801659358e2c5aa2253;p=thirdparty%2Flibsolv.git

decision.c: Simplify else condition

Found by Cppcheck: "Expression is always true because
'else if' condition is opposite to previous condition
at line 608." (multiCondition)
---

diff --git a/src/decision.c b/src/decision.c
index 353b80c8..d5b1f3b5 100644
--- a/src/decision.c
+++ b/src/decision.c
@@ -607,7 +607,7 @@ getdecisionlist(Solver *solv, Map *dm, int flags, Queue *decisionlistq)
       info = solv->decisionq_why.elements[ii];
       if (info > 0)
 	reason = SOLVER_REASON_UNIT_RULE;
-      else if (info <= 0)
+      else
 	{
 	  info = -info;
 	  reason = solv->decisionmap[vv];