From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 6 Mar 2025 14:39:40 +0000 (-0500)
Subject: remove '&' from sometimes module configuration
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1dea08febf329766fc71188e745dfded690a7536;p=thirdparty%2Ffreeradius-server.git

remove '&' from sometimes module configuration
---

diff --git a/doc/antora/modules/reference/pages/raddb/mods-available/sometimes.adoc b/doc/antora/modules/reference/pages/raddb/mods-available/sometimes.adoc
index 3d419cc111..ff1d59de12 100644
--- a/doc/antora/modules/reference/pages/raddb/mods-available/sometimes.adoc
+++ b/doc/antora/modules/reference/pages/raddb/mods-available/sometimes.adoc
@@ -31,7 +31,7 @@ Must be a number between 0 and 100.
 
 ```
 sometimes {
-	key = &User-Name
+	key = User-Name
 	rcode = fail
 	percentage = 1
 }
diff --git a/raddb/mods-available/sometimes b/raddb/mods-available/sometimes
index 9d4dded808..2c12b4bafb 100644
--- a/raddb/mods-available/sometimes
+++ b/raddb/mods-available/sometimes
@@ -20,7 +20,7 @@ sometimes {
 	#
 	#  key:: The `key` used for index.
 	#
-	key = &User-Name
+	key = User-Name
 
 	#
 	#  rcode:: Return code.
diff --git a/src/modules/rlm_sometimes/rlm_sometimes.c b/src/modules/rlm_sometimes/rlm_sometimes.c
index 5db3c66648..11a46f7430 100644
--- a/src/modules/rlm_sometimes/rlm_sometimes.c
+++ b/src/modules/rlm_sometimes/rlm_sometimes.c
@@ -41,7 +41,7 @@ typedef struct {
 
 static const conf_parser_t module_config[] = {
 	{ FR_CONF_OFFSET("rcode", rlm_sometimes_t, rcode_str), .dflt = "fail" },
-	{ FR_CONF_OFFSET_FLAGS("key", CONF_FLAG_ATTRIBUTE, rlm_sometimes_t, key), .dflt = "&User-Name", .quote = T_BARE_WORD },
+	{ FR_CONF_OFFSET_FLAGS("key", CONF_FLAG_ATTRIBUTE, rlm_sometimes_t, key), .dflt = "User-Name", .quote = T_BARE_WORD },
 	{ FR_CONF_OFFSET("percentage", rlm_sometimes_t, percentage), .dflt = "0" },
 	CONF_PARSER_TERMINATOR
 };