From: Yann Collet <cyan@fb.com>
Date: Thu, 11 Apr 2019 20:46:30 +0000 (-0700)
Subject: fixed timespec_get() initialization bug on some targets
X-Git-Tag: v1.4.0^2~6^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1e01560b83389e1fdf91eb9a8311d9a1c69abdce;p=thirdparty%2Fzstd.git

fixed timespec_get() initialization bug on some targets

not sure why, but msan fires an "unitialized variable" error
when time gets properly initialized by timespec_get().
Maybe in some cases, not all bytes of the structure are initialized ?
Or maybe msan fails to detect the initialization ?

Anyway, pre-initializing the variable before passing it to timespec_get() works.
---

diff --git a/programs/timefn.c b/programs/timefn.c
index 21f2a9618..096e1910b 100644
--- a/programs/timefn.c
+++ b/programs/timefn.c
@@ -91,8 +91,10 @@ PTime UTIL_getSpanTimeNano(UTIL_time_t clockStart, UTIL_time_t clockEnd)
 
 UTIL_time_t UTIL_getTime(void)
 {
-    UTIL_time_t time;
-    if (timespec_get(&time, TIME_UTC) == 0) {
+    /* time must be initialized, othersize it may fail msan test.
+     * No good reason, likely a limitation of timespec_get() for some target */
+    UTIL_time_t time = UTIL_TIME_INITIALIZER;
+    if (timespec_get(&time, TIME_UTC) != TIME_UTC) {
         perror("timefn::timespec_get");
         abort();
     }