From: Jeff Trawick Date: Wed, 26 May 2004 11:50:43 +0000 (+0000) Subject: back port this from 2.1-dev: X-Git-Tag: 2.0.50~68 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1e1c35493d4b6c051eabf1b7d7b00ee9a13c73b8;p=thirdparty%2Fapache%2Fhttpd.git back port this from 2.1-dev: mod_isapi: send_response_header() failed to copy status string's last character. PR: 20619 Submitted by: Jesse Pelton Reviewed by: trawick, stoddard, nd git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/APACHE_2_0_BRANCH@103773 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/CHANGES b/CHANGES index 4a5f33570c1..a803691852b 100644 --- a/CHANGES +++ b/CHANGES @@ -1,5 +1,8 @@ Changes with Apache 2.0.50 + *) mod_isapi: send_response_header() failed to copy status string's + last character. PR 20619. [Jesse Pelton ] + *) Fix a segfault when requests for shared memory fails and returns NULL. Fix a segfault caused by a lack of bounds checking on the cache. PR 24801 [Graham Leggett] diff --git a/STATUS b/STATUS index bcc300c4ef4..4b9b0e48236 100644 --- a/STATUS +++ b/STATUS @@ -1,5 +1,5 @@ APACHE 2.0 STATUS: -*-text-*- -Last modified at [$Date: 2004/05/25 23:45:45 $] +Last modified at [$Date: 2004/05/26 11:50:42 $] Release: @@ -392,11 +392,6 @@ PATCHES TO BACKPORT FROM 2.1 which implements this, keeping UseCanonicalName Off "as is". - * mod_isapi: send_response_header() failed to copy status string's - last character. PR 20619. [Jesse Pelton ] - http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/arch/win32/mod_isapi.c?r1=1.97&r2=1.98 - +1: trawick, stoddard, nd - * Unix MPMs: Stop dropping connections when the file descriptor is at least FD_SETSIZE os/unix/unixd.c: r1.63 diff --git a/modules/arch/win32/mod_isapi.c b/modules/arch/win32/mod_isapi.c index 0ed08aa9300..fed41609af3 100644 --- a/modules/arch/win32/mod_isapi.c +++ b/modules/arch/win32/mod_isapi.c @@ -684,7 +684,7 @@ static apr_ssize_t send_response_header(isapi_cid *cid, } newstat = apr_palloc(cid->r->pool, statlen + 9); strcpy(newstat, "Status: "); - apr_cpystrn(newstat + 8, stat, statlen); + apr_cpystrn(newstat + 8, stat, statlen + 1); stat = newstat; statlen += 8; }