From: Eduardo San Martin Morote Date: Mon, 2 May 2022 15:16:48 +0000 (+0200) Subject: chore: remove old todos X-Git-Tag: v4.1.0~130 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1e444852288b4e77cf33b8933668424f0e416aa5;p=thirdparty%2Fvuejs%2Frouter.git chore: remove old todos --- diff --git a/playground/router.ts b/playground/router.ts index 230b187c..45860e86 100644 --- a/playground/router.ts +++ b/playground/router.ts @@ -167,7 +167,6 @@ export const router = createRouter({ if (savedPosition) { return savedPosition } else { - // TODO: check if parent in common that works with alias if (to.matched.every((record, i) => from.matched[i] !== record)) return { left: 0, top: 0 } } diff --git a/src/navigationGuards.ts b/src/navigationGuards.ts index 6ce87477..b0b7fdff 100644 --- a/src/navigationGuards.ts +++ b/src/navigationGuards.ts @@ -194,7 +194,6 @@ export function guardToPromiseFn( } return resolvedValue }) - // TODO: test me! } else if (guardReturn !== undefined) { // @ts-expect-error: _called is added at canOnlyBeCalledOnce if (!next._called) { diff --git a/src/types/index.ts b/src/types/index.ts index 786cece5..b974d8f9 100644 --- a/src/types/index.ts +++ b/src/types/index.ts @@ -464,7 +464,6 @@ export interface NavigationHookAfter { ( to: RouteLocationNormalized, from: RouteLocationNormalized, - // TODO: move these types to a different file failure?: NavigationFailure | void ): any }