From: Volker Lendecke <vl@samba.org>
Date: Wed, 26 Nov 2025 11:08:33 +0000 (+0100)
Subject: libcli: Add missing NULL checks
X-Git-Tag: tdb-1.4.15~169
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1e53acaf31c6554b674fd81332af7bb7f4645494;p=thirdparty%2Fsamba.git

libcli: Add missing NULL checks

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/libcli/ldap/ldap_message.c b/libcli/ldap/ldap_message.c
index 19256c6ce62..eb2d77c84ae 100644
--- a/libcli/ldap/ldap_message.c
+++ b/libcli/ldap/ldap_message.c
@@ -1217,6 +1217,12 @@ _PUBLIC_ NTSTATUS ldap_decode(struct asn1_data *data,
 				}
 				*r->creds.SASL.secblob = data_blob_talloc(r->creds.SASL.secblob,
 									  tmp_blob.data, tmp_blob.length);
+				if ((tmp_blob.length != 0) &&
+				    (r->creds.SASL.secblob->data == NULL)) {
+					data_blob_free(&tmp_blob);
+					return NT_STATUS_LDAP(
+						LDAP_OPERATIONS_ERROR);
+				}
 				data_blob_free(&tmp_blob);
 			} else {
 				r->creds.SASL.secblob = NULL;
@@ -1245,6 +1251,11 @@ _PUBLIC_ NTSTATUS ldap_decode(struct asn1_data *data,
 			}
 			*r->SASL.secblob = data_blob_talloc(r->SASL.secblob,
 							    tmp_blob.data, tmp_blob.length);
+			if ((tmp_blob.length != 0) &&
+			    (r->SASL.secblob->data == NULL)) {
+				data_blob_free(&tmp_blob);
+				return NT_STATUS_LDAP(LDAP_OPERATIONS_ERROR);
+			}
 			data_blob_free(&tmp_blob);
 		} else {
 			r->SASL.secblob = NULL;