From: Stéphane Graber <stgraber@ubuntu.com>
Date: Fri, 14 Feb 2014 21:03:00 +0000 (-0500)
Subject: coverity: Check fstat return value
X-Git-Tag: lxc-1.0.0.rc2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1e98542850b1747138c899edd61ecbe43ff3ed55;p=thirdparty%2Flxc.git

coverity: Check fstat return value

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
---

diff --git a/src/lxc/lxc_user_nic.c b/src/lxc/lxc_user_nic.c
index 60176b174..a2f0c96b9 100644
--- a/src/lxc/lxc_user_nic.c
+++ b/src/lxc/lxc_user_nic.c
@@ -306,7 +306,10 @@ static bool cull_entries(int fd, char *me, char *t, char *br)
 
 	nic = alloca(100);
 
-	fstat(fd, &sb);
+	if (fstat(fd, &sb) < 0) {
+		fprintf(stderr, "Failed to fstat: %s", strerror(errno));
+		return false;
+	}
 	len = sb.st_size;
 	if (len == 0)
 		return true;
@@ -383,7 +386,10 @@ static bool get_nic_if_avail(int fd, char *me, int pid, char *intype, char *br,
 	if (allowed == 0)
 		return false;
 
-	fstat(fd, &sb);
+	if (fstat(fd, &sb) < 0) {
+		fprintf(stderr, "Failed to fstat: %s", strerror(errno));
+		return false;
+	}
 	len = sb.st_size;
 	if (len != 0) {
 		buf = mmap(NULL, len, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);