From: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Date: Thu, 9 Jul 2020 07:59:33 +0000 (+0300)
Subject: rpc: don't unref service ref on socket behalf twice
X-Git-Tag: v6.8.0-rc1~282
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1eae52b9f1f2c0232d14e0effa47e8e6e5cce28d;p=thirdparty%2Flibvirt.git

rpc: don't unref service ref on socket behalf twice

Second unref was added in [1]. We don't need it actually as
we pass free callback to virNetSocketAddIOCallback thus
when we call virNetSocketRemoveIOCallback the extra ref for
callback will be dropped without extra efforts.

[1] 355d8f470f9: virNetServerServiceClose: Don't leak sockets

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---

diff --git a/src/rpc/virnetserverservice.c b/src/rpc/virnetserverservice.c
index 9d5df456a8..e4165eacb7 100644
--- a/src/rpc/virnetserverservice.c
+++ b/src/rpc/virnetserverservice.c
@@ -449,6 +449,5 @@ void virNetServerServiceClose(virNetServerServicePtr svc)
     for (i = 0; i < svc->nsocks; i++) {
         virNetSocketRemoveIOCallback(svc->socks[i]);
         virNetSocketClose(svc->socks[i]);
-        virObjectUnref(svc);
     }
 }