From: Miod Vallat <miod.vallat@powerdns.com>
Date: Wed, 18 Feb 2026 07:13:22 +0000 (+0100)
Subject: Ignore port numbers in removeIf() if either ComboAddress lacks one.
X-Git-Tag: dnsdist-2.1.0-beta1~16^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1ec11cb0d328ef449f36bdcbeb08dd152a121ee4;p=thirdparty%2Fpdns.git

Ignore port numbers in removeIf() if either ComboAddress lacks one.

Fixes: #13576

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/pdns/communicator.hh b/pdns/communicator.hh
index f75f484b6e..3e27c7aa43 100644
--- a/pdns/communicator.hh
+++ b/pdns/communicator.hh
@@ -78,7 +78,7 @@ class NotificationQueue
 public:
   void add(const ZoneName& domain, const string& ipstring, time_t delay = 0)
   {
-    const ComboAddress ipaddress(ipstring);
+    const ComboAddress ipaddress(ipstring); // may not contain a port number
     add(domain, ipaddress, delay);
   }
 
@@ -98,7 +98,7 @@ public:
   {
     for (auto i = d_nqueue.begin(); i != d_nqueue.end(); ++i) {
       ComboAddress stQueued{i->ip};
-      if (i->id == id && stQueued == remote && i->domain == domain) {
+      if (i->id == id && ComboAddress::addressOnlyEqual()(stQueued, remote) && i->domain == domain) {
         d_nqueue.erase(i);
         return true;
       }