From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Tue, 10 May 2022 12:12:57 +0000 (+0200)
Subject: Do LOG_MESSAGE_VERIFICATION in coverity runs
X-Git-Tag: v251-rc3~14^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1ec7c15613028c75cf160a56bec0642a99109551;p=thirdparty%2Fsystemd.git

Do LOG_MESSAGE_VERIFICATION in coverity runs

This should be enough to get reports if we screw up anywhere, coverity does
analysis of printf format strings.
---

diff --git a/src/basic/log.h b/src/basic/log.h
index b03ca3ef21c..7b89c4df634 100644
--- a/src/basic/log.h
+++ b/src/basic/log.h
@@ -300,7 +300,7 @@ bool log_on_console(void) _pure_;
 
 /* Helper to wrap the main message in structured logging. The macro doesn't do much,
  * except to provide visual grouping of the format string and its arguments. */
-#if LOG_MESSAGE_VERIFICATION
+#if LOG_MESSAGE_VERIFICATION || defined(__COVERITY__)
 /* Do a fake formatting of the message string to let the scanner verify the arguments
  * against the format message. */
 #  define LOG_MESSAGE(fmt, ...) "MESSAGE=%.0d" fmt, printf(fmt, ##__VA_ARGS__), ##__VA_ARGS__