From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Tue, 27 Jun 2023 10:02:19 +0000 (+0200)
Subject: lib-imap-urlauth: imap-urlauth - Produce better user permission error message in... 
X-Git-Tag: 2.4.0~2506
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1ee5518e28caaad0163b203f9779e31d8b2ef441;p=thirdparty%2Fdovecot%2Fcore.git

lib-imap-urlauth: imap-urlauth - Produce better user permission error message in imap_urlauth_generate().
---

diff --git a/src/lib-imap-urlauth/imap-urlauth.c b/src/lib-imap-urlauth/imap-urlauth.c
index a83e71a883..c6c0e97be8 100644
--- a/src/lib-imap-urlauth/imap-urlauth.c
+++ b/src/lib-imap-urlauth/imap-urlauth.c
@@ -312,9 +312,14 @@ int imap_urlauth_generate(struct imap_urlauth_context *uctx,
 		*client_error_r = "Invalid URL: Missing user name";
 		return 0;
 	}
-	if (user->anonymous || strcmp(url->userid, user->username) != 0) {
+	if (user->anonymous) {
+		*client_error_r =
+			"Anonymous logins not permitted to generate URLAUTH";
+		return 0;
+	}
+	if (strcmp(url->userid, user->username) != 0) {
 		*client_error_r = t_strdup_printf(
-			"Not permitted to generate URLAUTH for user %s",
+			"Not permitted to generate URLAUTH for other user %s",
 			url->userid);
 		return 0;
 	}