From: Karel Zak Date: Thu, 1 Aug 2013 10:58:22 +0000 (+0200) Subject: more: fix buffer overflow X-Git-Tag: v2.24-rc1~417 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1ef2db5a5672e09fa1337099b7d9d6ab61c19bdc;p=thirdparty%2Futil-linux.git more: fix buffer overflow The bug has been probably introduced by commit 1ac300932deab8dea2c43050921bbbdb36d62ff1. Reported-by: "Dr. David Alan Gilbert" References: https://bugzilla.novell.com/show_bug.cgi?id=829720 Signed-off-by: Karel Zak --- diff --git a/text-utils/more.c b/text-utils/more.c index 3bbeede5d9..33771183c6 100644 --- a/text-utils/more.c +++ b/text-utils/more.c @@ -835,7 +835,8 @@ void prepare_line_buffer(void) if (nsz < LINSIZ) nsz = LINSIZ; - nline = xrealloc(Line, nsz); + /* alloc nsz and extra space for \n\0 */ + nline = xrealloc(Line, nsz + 2); Line = nline; LineLen = nsz; }