From: Michal Privoznik <mprivozn@redhat.com>
Date: Tue, 29 Nov 2016 13:59:25 +0000 (+0100)
Subject: nssmock: Prefer free() over VIR_FREE()
X-Git-Tag: v3.0.0-rc1~392
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1ef3ac82a3d31aca85529c42db36b94a7c0ca418;p=thirdparty%2Flibvirt.git

nssmock: Prefer free() over VIR_FREE()

Problem with VIR_FREE() is that we are not linking
libvirt-utils.so to our mock libs therefore there will be an
unresolved symbol. Fortunately, nsstest that eventually links
with the nssmock links also with libvirt-utils.so and thus the
symbol is resolved after all. However, if one wants to run the
test binary under valgrind it is impossible to do so. Because of
the unresolved symbol.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/cfg.mk b/cfg.mk
index a4305a808d..69e3f3a1af 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -1159,7 +1159,7 @@ exclude_file_name_regexp--sc_prohibit_select = \
 	^cfg\.mk$$
 
 exclude_file_name_regexp--sc_prohibit_raw_allocation = \
-  ^(docs/hacking\.html\.in|src/util/viralloc\.[ch]|examples/.*|tests/(securityselinuxhelper|vircgroupmock)\.c|tools/wireshark/src/packet-libvirt\.c)$$
+  ^(docs/hacking\.html\.in|src/util/viralloc\.[ch]|examples/.*|tests/(securityselinuxhelper|(vircgroup|nss)mock)\.c|tools/wireshark/src/packet-libvirt\.c)$$
 
 exclude_file_name_regexp--sc_prohibit_readlink = \
   ^src/(util/virutil|lxc/lxc_container)\.c$$
diff --git a/tests/nssmock.c b/tests/nssmock.c
index b0259a3776..273af0654a 100644
--- a/tests/nssmock.c
+++ b/tests/nssmock.c
@@ -91,7 +91,7 @@ open(const char *path, int flags, ...)
         ret = real_open(newpath ? newpath : path, flags);
     }
 
-    VIR_FREE(newpath);
+    free(newpath);
     return ret;
 }
 
@@ -109,7 +109,7 @@ opendir(const char *path)
 
     ret = real_opendir(newpath ? newpath : path);
 
-    VIR_FREE(newpath);
+    free(newpath);
     return ret;
 }
 #else