From: Mark Andrews <marka@isc.org>
Date: Wed, 5 Feb 2020 05:04:09 +0000 (+1100)
Subject: keymgr_keyrole couldn't emit "NOSIGN".
X-Git-Tag: v9.16.0~29^2~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1efc7550a3cf532cb5452f4c5fabe7c11a86d55a;p=thirdparty%2Fbind9.git

keymgr_keyrole couldn't emit "NOSIGN".

 92        } else {
 93                return ("ZSK");
 94        }

	CID 1455900 (#1 of 1): Structurally dead code (UNREACHABLE)
	unreachable: This code cannot be reached: return "NOSIGN";.

 95        return ("NOSIGN");
---

diff --git a/lib/dns/keymgr.c b/lib/dns/keymgr.c
index 8c1441cacd4..61bb3182e7e 100644
--- a/lib/dns/keymgr.c
+++ b/lib/dns/keymgr.c
@@ -89,7 +89,7 @@ keymgr_keyrole(dst_key_t* key)
 		return ("CSK");
 	} else if (ksk) {
 		return ("KSK");
-	} else {
+	} else if (zsk) {
 		return ("ZSK");
 	}
 	return ("NOSIGN");