From: Aurelien DARRAGON <adarragon@haproxy.com>
Date: Fri, 9 May 2025 14:34:27 +0000 (+0200)
Subject: MINOR: log: only run postcheck_log_backend() checks on backend
X-Git-Tag: v3.3-dev1~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1f12e45b0a890aa6d0212b0ca7b69edd44038d08;p=thirdparty%2Fhaproxy.git

MINOR: log: only run postcheck_log_backend() checks on backend

postcheck_log_backend() checks are executed no matter if the proxy
actually has the backend capability while the checks actually depend
on this.

Let's fix that by adding an extra condition to ensure that the BE
capability is set.

This issue is not tagged as a bug because for now it remains impossible
to have a syslog proxy without BE capability in the main proxy list, but
this may change in the future.
---

diff --git a/src/log.c b/src/log.c
index 9ca619856..12c8a3a4c 100644
--- a/src/log.c
+++ b/src/log.c
@@ -1348,7 +1348,7 @@ static int postcheck_log_backend(struct proxy *be)
 	int err_code = ERR_NONE;
 	int target_type = -1; // -1 is unused in log_tgt enum
 
-	if (be->mode != PR_MODE_SYSLOG ||
+	if (!(be->cap & PR_CAP_BE) || be->mode != PR_MODE_SYSLOG ||
 	    (be->flags & (PR_FL_DISABLED|PR_FL_STOPPED)))
 		return ERR_NONE; /* nothing to do */