From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 21 Aug 2023 01:52:14 +0000 (+1200)
Subject: s4:kdc: Check result of talloc_realloc()
X-Git-Tag: tevent-0.16.0~628
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1f20e557fc6099c4669cc4650291634fcef1026a;p=thirdparty%2Fsamba.git

s4:kdc: Check result of talloc_realloc()

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c
index 44e3b931ee0..7d8c2ff97b5 100644
--- a/source4/kdc/pac-glue.c
+++ b/source4/kdc/pac-glue.c
@@ -1349,6 +1349,12 @@ static NTSTATUS samba_kdc_update_delegation_info_blob(TALLOC_CTX *mem_ctx,
 	d->proxy_target.string = server;
 	d->transited_services = talloc_realloc(mem_ctx, d->transited_services,
 					       struct lsa_String, i + 1);
+	if (d->transited_services == NULL) {
+		SAFE_FREE(server);
+		SAFE_FREE(proxy);
+		talloc_free(tmp_ctx);
+		return NT_STATUS_INTERNAL_ERROR;
+	}
 	d->transited_services[i].string = proxy;
 	d->num_transited_services = i + 1;