From: Nathan Neulinger <nneul@neulinger.org>
Date: Wed, 17 Sep 2014 16:13:15 +0000 (-0500)
Subject: mod_skinny: avoid truncation of non-null-terminated strings in protocol
X-Git-Tag: v1.4.8~1^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1f5bb3470dbbe7d1582b7783661afa0928794b54;p=thirdparty%2Ffreeswitch.git

mod_skinny: avoid truncation of non-null-terminated strings in protocol
---

diff --git a/src/mod/endpoints/mod_skinny/skinny_protocol.c b/src/mod/endpoints/mod_skinny/skinny_protocol.c
index 5f3a831345..fc4ee532a0 100644
--- a/src/mod/endpoints/mod_skinny/skinny_protocol.c
+++ b/src/mod/endpoints/mod_skinny/skinny_protocol.c
@@ -501,7 +501,7 @@ switch_status_t perform_send_register_ack(listener_t *listener,
 	skinny_create_message(message, REGISTER_ACK_MESSAGE, reg_ack);
 
 	message->data.reg_ack.keep_alive = keep_alive;
-	switch_copy_string(message->data.reg_ack.date_format, date_format, 6);
+	memcpy(message->data.reg_ack.date_format, date_format, 6);
 	switch_copy_string(message->data.reg_ack.reserved, reserved, 2);
 	message->data.reg_ack.secondary_keep_alive = keep_alive;
 	switch_copy_string(message->data.reg_ack.reserved2, reserved2, 4);
@@ -871,7 +871,7 @@ switch_status_t perform_send_version(listener_t *listener,
 
 	skinny_create_message(message, VERSION_MESSAGE, version);
 
-	switch_copy_string(message->data.version.version, version, 16);
+	memcpy(message->data.version.version, version, 16);
 
 	skinny_log_l_ffl(listener, file, func, line, SWITCH_LOG_DEBUG,
 		"Send Version with Version(%s)\n", version);