From: Jim Meyering <meyering@redhat.com>
Date: Sat, 21 Mar 2009 08:56:00 +0000 (+0100)
Subject: tests: modernize: use $(var) makefile notation, not @var@
X-Git-Tag: v7.2~22
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1f95a450996aae2e99c02241f31ffd370db2e472;p=thirdparty%2Fcoreutils.git

tests: modernize: use $(var) makefile notation, not @var@

* maint.mk (sc_makefile_path_separator_check): Recommend
the use of $(PATH_SEPARATOR), not @PATH_SEPARATOR@.
Remove an obsolete comment.
---

diff --git a/maint.mk b/maint.mk
index 0c1ad24a6b..17f0be83fe 100644
--- a/maint.mk
+++ b/maint.mk
@@ -581,11 +581,8 @@ sc_po_check:
 
 # Sometimes it is useful to change the PATH environment variable
 # in Makefiles.  When doing so, it's better not to use the Unix-centric
-# path separator of `:', but rather the automake-provided `@PATH_SEPARATOR@'.
-# It'd be better to use `find -print0 ...|xargs -0 ...', but less portable,
-# and there probably aren't many projects with so many Makefile.am files
-# that we'd have to worry about limits on command line length.
-msg = '$(ME): Do not use `:'\'' above; use @PATH_SEPARATOR@ instead'
+# path separator of `:', but rather the automake-provided `$(PATH_SEPARATOR)'.
+msg = '$(ME): Do not use `:'\'' above; use $$(PATH_SEPARATOR) instead'
 sc_makefile_path_separator_check:
 	@grep -n 'PATH=.*:' `find $(srcdir) -name Makefile.am` \
 	  && { echo $(msg) 1>&2; exit 1; } || :