From: Daniel Salzman <daniel.salzman@nic.cz>
Date: Wed, 17 Sep 2025 06:44:21 +0000 (+0200)
Subject: keymgr: fix possible NULL dereference when parsing import-key params (clang analyzer)
X-Git-Tag: v3.5.0~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1fa4974f99e1845e0c4002b1220d62af248f567f;p=thirdparty%2Fknot-dns.git

keymgr: fix possible NULL dereference when parsing import-key params (clang analyzer)
---

diff --git a/src/utils/keymgr/functions.c b/src/utils/keymgr/functions.c
index 7276a93bf4..f60e497a18 100644
--- a/src/utils/keymgr/functions.c
+++ b/src/utils/keymgr/functions.c
@@ -180,7 +180,7 @@ static bool genkeyargs(int argc, char *argv[], bool just_timing,
 				ERR2("invalid size: '%s'", argv[i] + 5);
 				return false;
 			}
-		} else if (!just_timing && same_command(argv[i], "addtopolicy=", true)) {
+		} else if (!just_timing && same_command(argv[i], "addtopolicy=", true) && addtopolicy != NULL) {
 			*addtopolicy = argv[i] + 12;
 		} else if (same_command_bool(argv[i], "ksk", &res)) {
 			bitmap_set(flags, DNSKEY_GENERATE_KSK, res);