From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 7 Aug 2023 04:47:10 +0000 (+1200)
Subject: s3:printing: Add missing newlines to logging messages
X-Git-Tag: tevent-0.16.0~1139
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1fbfe05023e22e65711461130464efab63ea514e;p=thirdparty%2Fsamba.git

s3:printing: Add missing newlines to logging messages

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/printing/print_cups.c b/source3/printing/print_cups.c
index 4d83d398675..d8ba9ccd011 100644
--- a/source3/printing/print_cups.c
+++ b/source3/printing/print_cups.c
@@ -1107,7 +1107,7 @@ static int cups_job_submit(int snum, struct printjob *pjob,
 				pjob->sysjob = ippGetInteger(attr_job_id, 0);
 				DEBUG(5,("cups_job_submit: job-id %d\n", pjob->sysjob));
 			} else {
-				DEBUG(0,("Missing job-id attribute in IPP response"));
+				DEBUG(0,("Missing job-id attribute in IPP response\n"));
 			}
 		}
 	} else {
@@ -1301,7 +1301,7 @@ static int cups_queue_get(const char *sharename,
 			queue = SMB_REALLOC_ARRAY(queue, print_queue_struct, qalloc);
 
 			if (queue == NULL) {
-				DEBUG(0,("cups_queue_get: Not enough memory!"));
+				DEBUG(0,("cups_queue_get: Not enough memory!\n"));
 				qcount = 0;
 				goto out;
 			}
diff --git a/source3/printing/print_iprint.c b/source3/printing/print_iprint.c
index 6600d954ded..2b2215eb8c3 100644
--- a/source3/printing/print_iprint.c
+++ b/source3/printing/print_iprint.c
@@ -1205,7 +1205,7 @@ static int iprint_queue_get(const char *sharename,
 			queue = SMB_REALLOC_ARRAY(queue, print_queue_struct, qalloc);
 
 			if (queue == NULL) {
-				DEBUG(0,("iprint_queue_get: Not enough memory!"));
+				DEBUG(0,("iprint_queue_get: Not enough memory!\n"));
 				qcount = 0;
 				goto out;
 			}
diff --git a/source3/printing/printer_list.c b/source3/printing/printer_list.c
index 8ff75dc6bdd..3430d2b7d17 100644
--- a/source3/printing/printer_list.c
+++ b/source3/printing/printer_list.c
@@ -98,7 +98,7 @@ NTSTATUS printer_list_get_printer(TALLOC_CTX *mem_ctx,
 			 PL_DATA_FORMAT,
 			 &time_h, &time_l, &nstr, &cstr, &lstr);
 	if (ret == -1) {
-		DEBUG(1, ("Failed to un pack printer data"));
+		DEBUG(1, ("Failed to un pack printer data\n"));
 		status = NT_STATUS_INTERNAL_DB_CORRUPTION;
 		goto done;
 	}
@@ -249,7 +249,7 @@ NTSTATUS printer_list_get_last_refresh(time_t *last_refresh)
 			 PL_TSTAMP_FORMAT, &time_h, &time_l);
 	TALLOC_FREE(data.dptr);
 	if (ret == -1) {
-		DEBUG(1, ("Failed to un pack printer data"));
+		DEBUG(1, ("Failed to un pack printer data\n"));
 		status = NT_STATUS_INTERNAL_DB_CORRUPTION;
 		goto done;
 	}
@@ -354,7 +354,7 @@ static int printer_list_clean_fn(struct db_record *rec, void *private_data)
 			 PL_DATA_FORMAT, &time_h, &time_l, &name, &comment,
 			 &location);
 	if (ret == -1) {
-		DEBUG(1, ("Failed to un pack printer data"));
+		DEBUG(1, ("Failed to un pack printer data\n"));
 		state->status = NT_STATUS_INTERNAL_DB_CORRUPTION;
 		return -1;
 	}
@@ -427,7 +427,7 @@ static int printer_list_exec_fn(struct db_record *rec, void *private_data)
 			 PL_DATA_FORMAT, &time_h, &time_l, &name, &comment,
 			 &location);
 	if (ret == -1) {
-		DEBUG(1, ("Failed to un pack printer data"));
+		DEBUG(1, ("Failed to un pack printer data\n"));
 		state->status = NT_STATUS_INTERNAL_DB_CORRUPTION;
 		return -1;
 	}
diff --git a/source3/printing/printing.c b/source3/printing/printing.c
index 5cf170d4dae..9d7cd55c05c 100644
--- a/source3/printing/printing.c
+++ b/source3/printing/printing.c
@@ -2097,7 +2097,7 @@ WERROR print_job_delete(const struct auth_session_info *server_info,
 	    !W_ERROR_IS_OK(print_access_check(server_info, msg_ctx, snum,
 					      JOB_ACCESS_ADMINISTER))) {
 		DEBUG(0, ("print job delete denied."
-			  "User name: %s, Printer name: %s.",
+			  "User name: %s, Printer name: %s.\n",
 			  uidtoname(server_info->unix_token->uid),
 			  lp_printername(tmp_ctx, lp_sub, snum)));
 
@@ -2184,7 +2184,7 @@ WERROR print_job_pause(const struct auth_session_info *server_info,
 	    !W_ERROR_IS_OK(print_access_check(server_info, msg_ctx, snum,
 					      JOB_ACCESS_ADMINISTER))) {
 		DEBUG(0, ("print job pause denied."
-			  "User name: %s, Printer name: %s.",
+			  "User name: %s, Printer name: %s.\n",
 			  uidtoname(server_info->unix_token->uid),
 			  lp_printername(tmp_ctx, lp_sub, snum)));
 
@@ -2253,7 +2253,7 @@ WERROR print_job_resume(const struct auth_session_info *server_info,
 	    !W_ERROR_IS_OK(print_access_check(server_info, msg_ctx, snum,
 					      JOB_ACCESS_ADMINISTER))) {
 		DEBUG(0, ("print job resume denied."
-			  "User name: %s, Printer name: %s.",
+			  "User name: %s, Printer name: %s.\n",
 			  uidtoname(server_info->unix_token->uid),
 			  lp_printername(tmp_ctx, lp_sub, snum)));