From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 18 Nov 2013 18:06:06 +0000 (+0100)
Subject: utils: nfsynproxy: fix error while compiling the BPF filter
X-Git-Tag: v1.4.21~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1fc21d3696cb108723bf7ab2b5d07a63e3701201;p=thirdparty%2Fiptables.git

utils: nfsynproxy: fix error while compiling the BPF filter

Fix the following error while running nfsynproxy here:

 pcap_compile: not-yet-activated pcap_t passed to pcap_compile

According to what I have read, we have to compile the filter
once the pcap_t handle has been activated.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/utils/nfsynproxy.c b/utils/nfsynproxy.c
index 9b6de93b..baedc92c 100644
--- a/utils/nfsynproxy.c
+++ b/utils/nfsynproxy.c
@@ -109,20 +109,20 @@ static void probe_host(const char *host)
 		goto err2;
 	}
 
-	if (pcap_compile(ph, &fp, "src host 127.0.0.1 and tcp and src port 80",
-			 1, PCAP_NETMASK_UNKNOWN) == -1) {
-		pcap_perror(ph, "pcap_compile");
-		goto err2;
-	}
-
 	if (pcap_setfilter(ph, &fp) == -1) {
 		pcap_perror(ph, "pcap_setfilter");
-		goto err3;
+		goto err2;
 	}
 
 	if (pcap_activate(ph) != 0) {
 		pcap_perror(ph, "pcap_activate");
-		goto err3;
+		goto err2;
+	}
+
+	if (pcap_compile(ph, &fp, "src host 127.0.0.1 and tcp and src port 80",
+			 1, PCAP_NETMASK_UNKNOWN) == -1) {
+		pcap_perror(ph, "pcap_compile");
+		goto err2;
 	}
 
 	fd = socket(AF_INET, SOCK_STREAM, 0);