From: Philippe Waroquiers Date: Wed, 16 Jan 2013 22:07:02 +0000 (+0000) Subject: Small comment fix: .h specifies "all frames", implementation uses 8. X-Git-Tag: svn/VALGRIND_3_9_0~446 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1fcd3182397415a8dc75fbceeaa060da089a9e8e;p=thirdparty%2Fvalgrind.git Small comment fix: .h specifies "all frames", implementation uses 8. Two fixes could be done: Either we fix the comments or we increase N_FRAMES to be rather VG_DEEPEST_BACKTRACE. We fix the comment for the following reason: This is (at least for the moment) not performance critical. as this is only called when an error is reported. However, searching for local vars is extremely costly. It is unlikely that an error is reported for a stack variable which is more than 8 frames deeper than theframe in which it is detected. So, fix the comment, waiting for a complaint that a deeper variable is not properly described. git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13235 --- diff --git a/coregrind/m_debuginfo/debuginfo.c b/coregrind/m_debuginfo/debuginfo.c index d3b8ef4ace..95e1ea0409 100644 --- a/coregrind/m_debuginfo/debuginfo.c +++ b/coregrind/m_debuginfo/debuginfo.c @@ -3171,7 +3171,7 @@ Bool consider_vars_in_frame ( /*MOD*/XArray* /* of HChar */ dname1, } /* Try to form some description of DATA_ADDR by looking at the DWARF3 - debug info we have. This considers all global variables, and all + debug info we have. This considers all global variables, and 8 frames in the stacks of all threads. Result is written at the ends of DNAME{1,2}V, which are XArray*s of HChar, that have been initialised by the caller, and True is returned. If no description diff --git a/include/pub_tool_debuginfo.h b/include/pub_tool_debuginfo.h index 2875282856..d4cb6d8ab7 100644 --- a/include/pub_tool_debuginfo.h +++ b/include/pub_tool_debuginfo.h @@ -96,7 +96,7 @@ extern Bool VG_(get_datasym_and_offset)( Addr data_addr, /*OUT*/PtrdiffT* offset ); /* Try to form some description of DATA_ADDR by looking at the DWARF3 - debug info we have. This considers all global variables, and all + debug info we have. This considers all global variables, and 8 frames in the stacks of all threads. Result is written at the ends of DNAME{1,2}V, which are XArray*s of HChar, that have been initialised by the caller, and True is returned. If no description