From: Amos Jeffries <squid3@treenet.co.nz>
Date: Fri, 11 Jan 2013 06:31:01 +0000 (-0700)
Subject: ext_unix_group_acl: remove useless check for NULL
X-Git-Tag: SQUID_3_4_0_1~387
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1fd5d1afcca6e1ca995f0700860212af102fe898;p=thirdparty%2Fsquid.git

ext_unix_group_acl: remove useless check for NULL

* the string in p is checked for NULL prior to being assigned to user
  there is no need to check it twice and doing so confuses Coverity.

 Detected by Coverity Scan. Issue 740451.
---

diff --git a/helpers/external_acl/unix_group/check_group.cc b/helpers/external_acl/unix_group/check_group.cc
index e0cd04b64e..769750cce2 100644
--- a/helpers/external_acl/unix_group/check_group.cc
+++ b/helpers/external_acl/unix_group/check_group.cc
@@ -206,7 +206,7 @@ main(int argc, char *argv[])
         } else {
             user = p;
             rfc1738_unescape(user);
-            if (user && strip_dm) {
+            if (strip_dm) {
                 suser = strchr(user, '\\');
                 if (!suser) suser = strchr(user, '/');
                 if (suser && suser[1]) user = suser + 1;