From: Ján Tomko <jtomko@redhat.com>
Date: Sun, 2 Aug 2020 11:37:20 +0000 (+0200)
Subject: util: remove virStringListCopy
X-Git-Tag: v6.7.0-rc1~218
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=201dcc16906cdbd398056aea175d1dfde1513546;p=thirdparty%2Flibvirt.git

util: remove virStringListCopy

The g_strdupv function from GLib provides
the same functionality.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/util/virstring.c b/src/util/virstring.c
index 2d7ddc4676..9da811b2ec 100644
--- a/src/util/virstring.c
+++ b/src/util/virstring.c
@@ -259,43 +259,6 @@ virStringListMerge(char ***dst,
 }
 
 
-/**
- * virStringListCopy:
- * @dst: where to store the copy of @strings
- * @src: a NULL-terminated array of strings
- *
- * Makes a deep copy of the @src string list and stores it in @dst. Callers
- * are responsible for freeing @dst.
- *
- * Returns 0 on success, -1 on error.
- */
-int
-virStringListCopy(char ***dst,
-                  const char **src)
-{
-    char **copy = NULL;
-    size_t i;
-
-    *dst = NULL;
-
-    if (!src)
-        return 0;
-
-    if (VIR_ALLOC_N(copy, virStringListLength(src) + 1) < 0)
-        goto error;
-
-    for (i = 0; src[i]; i++)
-        copy[i] = g_strdup(src[i]);
-
-    *dst = copy;
-    return 0;
-
- error:
-    virStringListFree(copy);
-    return -1;
-}
-
-
 /**
  * virStringListFree:
  * @strings: a NULL-terminated array of strings to free
diff --git a/src/util/virstring.h b/src/util/virstring.h
index c812157287..00be951956 100644
--- a/src/util/virstring.h
+++ b/src/util/virstring.h
@@ -45,9 +45,6 @@ void virStringListRemove(char ***strings,
 int virStringListMerge(char ***dst,
                        char ***src);
 
-int virStringListCopy(char ***dst,
-                      const char **src);
-
 void virStringListFree(char **strings);
 void virStringListAutoFree(char ***strings);
 void virStringListFreeCount(char **strings,