From: Roman Bogorodskiy <bogorodskiy@gmail.com>
Date: Thu, 31 Jan 2019 12:37:01 +0000 (+0400)
Subject: bhyve: emit warning when using bhyve:commandline
X-Git-Tag: v5.1.0-rc1~267
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=205518836376ca6be499f6ea985671284227d5f8;p=thirdparty%2Flibvirt.git

bhyve: emit warning when using bhyve:commandline

When using custom command line arguments, warn that
this configuration is not fully supported.

Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
index a1ae2026a0..1f215dac08 100644
--- a/src/bhyve/bhyve_command.c
+++ b/src/bhyve/bhyve_command.c
@@ -630,6 +630,10 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn,
     if (def->namespaceData) {
         bhyveDomainCmdlineDefPtr bhyvecmd;
 
+        VIR_WARN("Booting the guest using command line pass-through feature, "
+                 "which could potentially cause inconsistent state and "
+                 "upgrade issues");
+
         bhyvecmd = def->namespaceData;
         for (i = 0; i < bhyvecmd->num_args; i++)
             virCommandAddArg(cmd, bhyvecmd->args[i]);